UCP: tm offload rndv support #1549
Conversation
|
Test FAILed. |
|
Test FAILed. |
|
Test FAILed. |
src/ucp/tag/offload.c
Outdated
| uint64_t remote_addr, size_t length, | ||
| const void *rkey_buf) | ||
| { | ||
| ucp_rndv_rts_hdr_t *rts = (ucp_rndv_rts_hdr_t*)(((ucp_tag_hdr_t*)hdr) - 1); |
There was a problem hiding this comment.
isn't this illegal to access memory before 'hdr'?
src/ucp/tag/offload.c
Outdated
|
|
||
| ucs_status_t ucp_tag_offload_rndv_zcopy(uct_pending_req_t *self) | ||
| { | ||
| void *rndv_op; |
There was a problem hiding this comment.
pls move this variable to be last, so variables with initializers are first
|
Test PASSed. |
|
Test PASSed. |
|
Test PASSed. |
|
Test PASSed. |
|
Test PASSed. |
|
Test PASSed. |
src/ucp/tag/rndv.c
Outdated
| sizeof(*rndv_rts_hdr), recv_flags); | ||
| } | ||
|
|
||
| UCP_THREAD_CS_EXIT_CONDITIONAL(&context->mt_lock); | ||
| return status; | ||
| } | ||
|
|
||
| ucs_status_t ucp_rndv_rts_handler(void *arg, void *data, size_t length, |
There was a problem hiding this comment.
need to move UCS_PROFILE_FUNC to this function instead of ucp_rndv_process_rts, and add UCS_PROFILE_FUNC to ucp_tag_offload_unexp_rndv. This is because we need to profile the entry points from UCT to UCP.
src/ucp/tag/offload.c
Outdated
| if (status != UCS_OK) { | ||
| ucs_error("Failed to cancel recv in the transport: %s", | ||
| ucs_status_string(status)); | ||
| if (req->flags & UCP_REQUEST_FLAG_OFFLOADED) { |
src/ucp/tag/offload.c
Outdated
| ucp_worker_iface_t, queue); | ||
| ucp_rndv_rts_hdr_t rts; | ||
|
|
||
| rts.sreq = sreq->super; |
There was a problem hiding this comment.
pls add comment like "emulate rts without key"
|
Test PASSed. |
|
Test PASSed. |
@yosefe pls take a look